New boards Wishlist
I have added T-Display S3 Long to my own fork. How do I add it to your repo?
Board
Other / not listed here
Your question
Hello,
I have made a fork of your repo and added (with some help from Codex) a new board to this great software. It is the Lilygo T-Display S3 Long board. I have tested it and it seems to work ok.
Question is now, how do I get this board in your repo. Because only after a few days I am some releases behind. The working version is based on firmware 0.11.
The T-Display S3 long is a 3.4" 640x180 IPS touch screen. and it is perfect for placing under a desk for example to control a motorized desk and all the lights ect. in an office
Discussion 8
Add a commentHi Remco,
You can open a pull request directly from your branch into this repository using this link: https://github.com/MaxGramser/homeassistant_espscreen/compare/main...rhannink:homeassistant_espscreen:feat/lilygo-tdisplay-s3-long
Just click the green "Create pull request" button on that page, give it a title like "Add Lilygo T-Display S3 Long board support", and submit it so Max can review and merge it into the project.
Since your branch is currently based on 0.11 and 15 commits behind the latest main, it is also a good idea to sync your fork main branch (via the "Sync fork" button on your fork page on GitHub) and merge or rebase the latest changes into your branch if you run into any merge conflicts.
Hope this helps!
Original on GitHub
supercool that you got it to work! But i'm a bit hesitant... How does the overlay screens look? like climate? This feels like a very limited screen to be included in the full list.
Original on GitHub
· Edited
I have also changed all the overlay screens to fit on this screen. As example here the climate, media player and CWWW light.
Original on GitHub
did you also test when climate has all the options? and vacuum? and how's the UI for overlay blinds with sliders?
Original on GitHub
· Edited
I have no vacuum entity in the house, so I cannot test this. Regarding the climate and the curtains, you mean this?
Original on GitHub
Thanks @rhannink! This is better suited to a discussion than an issue, so I moved it here: https://github.com/MaxGramser/homeassistant_espscreen/discussions/101
Please continue the conversation there. I'm closing this issue to keep the tracker for bugs and concrete board requests.
Got a screen running? Tell others which board you have and what works on the Tessera website. It helps everyone pick a screen that works.
Like my work? Consider buying me a coffee, much appreciated!
Original on GitHub
I resync my fork to the latest code and made a PR. I hope you will add this board. If you need me to do some more tests or change code, please let me know.
I will buy you a coffee anyhow ;-)
Gr. Remco
Original on GitHub
Nice work — the normal way to contribute this board back is to open a pull request from a branch in your fork.
Because your implementation is based on an older release, I would first replay it on top of the current upstream branch instead of opening the PR directly from the old branch:
Then bring only your board-related commits into that new branch:
If the default branch is not
main, replace it with the repository's default branch. If you have several commits, you can cherry-pick them in order or use a commit range.After pushing, open your fork on GitHub and click Contribute → Open pull request. The base should be this repository's current default branch, and the head should be
your-fork:feat/t-display-s3-long.In the PR, it would help to include:
Starting the feature branch from the latest upstream commit avoids mixing your contribution with the fact that the fork is a few releases behind. If cherry-pick reports conflicts, resolve them on this new branch, build/test again, and then push the resolved version.
Original on GitHub